Changed (hard-coded) mcgui 3D visualiser to be webgl-classic#2381
Merged
willend merged 7 commits intomccode-dev:mainfrom Mar 30, 2026
Merged
Changed (hard-coded) mcgui 3D visualiser to be webgl-classic#2381willend merged 7 commits intomccode-dev:mainfrom
willend merged 7 commits intomccode-dev:mainfrom
Conversation
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Some users find the
Simulation->Display-3Dshortcut frommcguiconvenient. It is however unfortunately run in a 'blocking' mode, which means that especially on first (time-consuming due tonode.jsmodule installation) launch ofmcdisplay-webglthere is a high probability (especially on Windows) that the user will interruptmcgui/ the install process, leading to a brokenmcdisplay-webglsetup.I have therefore changed the
Simulation->Display-3Dvisualiser to launch the snappier (but simpler)mcdisplay-webgl-classictool.Fixes issue #2380
Development OS / boundary conditions
Manually tested on macOS, Ubuntu and Windows.
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My PR is meant to fix a specific, existing issue
My contribution contains something else