Example instrument with adjustable ESS pulse-length.#2430
Merged
willend merged 3 commits intomccode-dev:mainfrom Apr 30, 2026
Merged
Example instrument with adjustable ESS pulse-length.#2430willend merged 3 commits intomccode-dev:mainfrom
willend merged 3 commits intomccode-dev:mainfrom
Conversation
Contributor
Author
|
This error on windows / without conda is understood: False positive. The ESS_butterfly.comp was touched, meaning that all instruments including that component were tested/compile attempted. (And currently MCPL is for some reason not functional in this limited importance workflow.) |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Add example instrument that allows adjusting ESS pulse-length.
Ingredients:
pulse_durationADJUSTABLE_ESS_PULSEDEPENDENCY “ -DADJUSTABLE_ESS_PULSE “in the instrument file.This PR constitutes a first implementation, improvements may come later.
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
PR Checklist for contributing to McStas/McXtrace
My contribution includes patches to an existing component file
mcdocutility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)mctestutility to test one or more instruments making use of the component (please attachmcviewtestreport as screenshot in comments)mccode-clangformattool to apply the standard McCode component indentation schememcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedMy contribution includes a new instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)%Example:line to describe expected behaviourmcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedexampleshierarchy in a folder in the style ofexamples/ESS/New_stuff/New_stuff.instrexamplefolder, but if general use I have placed it in the globaldatafolder.My work touches / adds to the runtime lib code (.c,.h etc in multiple locations
My contribution contains something else