Provide SCATTER_func for libraries to replicate SCATTER functionality#2535
Merged
Conversation
…tion of the ray to plotting. That makro is however not available within .c and .h files in share, so components that do most work there can not visualize the ray path in mcdisplay. Here a small function that replicate SCATTER is added to McStas and McXtrace. It is used in conic.h to show the ray path within nested mirror optics.
Contributor
|
Nice! I thought you mentioned something about a similar solution in use in ESS_butterfly-related share code, yet I don’t seem to find anything like that now? |
Contributor
Author
|
The library used in the butterfly component just had mcdisplay function calls, making me realize we could do things like this |
Contributor
|
OK. Then I will merge like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
The SCATTER keyword works in components and provides the current position of the ray to plotting.
That makro is however not available within .c and .h files in share, so components that do most work there can not visualize the ray path in mcdisplay. Here a small function that replicate SCATTER is added to McStas and McXtrace. It is used in conic.h to show the ray path within nested mirror optics.
The function is called SCATTER_func and takes a pointer to the particle, _particle. It returns void.
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
OS X
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My work touches / adds to the runtime lib code (.c,.h etc in multiple locations