Skip to content

Hotfixes for issues#175

Merged
jpmorgan98 merged 20 commits intomcdc-project:mainfrom
jpmorgan98:main
Mar 27, 2024
Merged

Hotfixes for issues#175
jpmorgan98 merged 20 commits intomcdc-project:mainfrom
jpmorgan98:main

Conversation

@jpmorgan98
Copy link
Copy Markdown
Collaborator

@jpmorgan98 jpmorgan98 commented Mar 23, 2024

Opening this PR for easier contribution, do not approve until all changes have been responded. I have responded to most of reviewers comments and made some edits

Changes:

  • Adding doc strings to public functions in input_.py
  • Adding a runtime error for when a continuous energy xsec library is uninitiated
  • Fixing plotting and other functions
  • Adding some extra notes to the MPI users guide and links to the reference solution Missing/incomplete Documentation #174

Still need to be responded to:

  • @spasmann, can you edit the iqmc docstring?
  • eigenvalue/smrg7 fails with ERROR: Particle census bank is full Broken examples #173
  • c5g7/3d/TDX the default particle number does not resolve to the reference solution.
  • eigenvalue/2d_c5g7 fails to plot with the following error. I think this is due to the "C" argument to pcolormesh only having 1 dimension

@jpmorgan98 jpmorgan98 requested a review from clemekay March 23, 2024 20:03
@jpmorgan98 jpmorgan98 marked this pull request as draft March 23, 2024 20:03
@jpmorgan98 jpmorgan98 self-assigned this Mar 24, 2024
@jpmorgan98 jpmorgan98 added bug Something isn't working as intended documentation Improvements or additions to documentation labels Mar 27, 2024
@jpmorgan98 jpmorgan98 marked this pull request as ready for review March 27, 2024 22:33
@jpmorgan98 jpmorgan98 merged commit 93d1774 into mcdc-project:main Mar 27, 2024
melekderman pushed a commit to melekderman/MCDC that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as intended documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants