Merged
Conversation
Events are based on a binary representation for event types
jpmorgan98
requested changes
Apr 21, 2023
Collaborator
jpmorgan98
left a comment
There was a problem hiding this comment.
Alterations should have more comments to alleviate readability issues. Failed unit test suit. Output below:
==================================== test session starts =====================================
platform linux -- Python 3.10.6, pytest-7.2.2, pluggy-1.0.0
rootdir: /home/jpm_pop/workspace/testing/MCDC, configfile: pytest.ini
collected 40 items
test/regression/eigenvalue/2d_c5g7/test_1.py . [ 2%]
test/regression/eigenvalue/inf_shem361/test.py . [ 5%]
test/regression/eigenvalue/slab_2gu_iqmc/test.py F [ 7%]
test/regression/eigenvalue/slab_kornreich/test.py F [ 10%]
test/regression/eigenvalue/slab_kornreich_iqmc/test.py F [ 12%]
test/regression/eigenvalue/smrg7/test.py F [ 15%]
test/regression/fixed_source/C5G7-TDX/test.py F [ 17%]
test/regression/fixed_source/C5G7-TDX/test_2.py F [ 20%]
test/regression/fixed_source/azurv1_pl_super/test.py F [ 22%]
test/regression/fixed_source/cooper2/test.py F [ 25%]
test/regression/fixed_source/cooper2_iqmc/test.py F [ 27%]
test/regression/fixed_source/dsm_azurv1/test.py F [ 30%]
test/regression/fixed_source/dsm_lattice/test.py F [ 32%]
test/regression/fixed_source/inf_casmo70/test.py F [ 35%]
test/regression/fixed_source/inf_casmo70_td/test.py F [ 37%]
test/regression/fixed_source/kobayashi3TD/test.py F [ 40%]
test/regression/fixed_source/reed/test.py F [ 42%]
test/regression/fixed_source/reed_iqmc/test.py F [ 45%]
test/regression/fixed_source/slab_absorbium/test.py F [ 47%]
test/regression/fixed_source/slab_isobeam_td/test.py F [ 50%]
test/regression/fixed_source/slab_moving/test.py F [ 52%]
test/unit/test_input_.py ........ [ 72%]
test/unit/test_kernel.py . [ 75%]
test/unit/test_loop.py ... [ 82%]
test/unit/test_surface.py . [ 85%]
test/unit/test_type_.py ...... [100%]
ilhamv
reviewed
Apr 23, 2023
Member
There was a problem hiding this comment.
Love the idea! But, does it pass the tests? Also, did you make sure that it runs in Numba mode as well @goodman17c ?
ilhamv
approved these changes
May 17, 2023
Member
ilhamv
left a comment
There was a problem hiding this comment.
It passes the tests and runs on Numba mode
clemekay
pushed a commit
to clemekay/MCDC
that referenced
this pull request
Nov 2, 2023
Refactor of the event system
melekderman
pushed a commit
to melekderman/MCDC
that referenced
this pull request
Apr 18, 2025
Refactor of the event system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Events are based on a binary representation for event types.
This refactor allows for more complexity of event types and simplification of code and development.