Skip to content

Refactor of the event system#97

Merged
ilhamv merged 8 commits intomcdc-project:mainfrom
goodman17c:Event-System-Rework
May 17, 2023
Merged

Refactor of the event system#97
ilhamv merged 8 commits intomcdc-project:mainfrom
goodman17c:Event-System-Rework

Conversation

@goodman17c
Copy link
Copy Markdown
Contributor

Events are based on a binary representation for event types.
This refactor allows for more complexity of event types and simplification of code and development.

Copy link
Copy Markdown
Collaborator

@jpmorgan98 jpmorgan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alterations should have more comments to alleviate readability issues. Failed unit test suit. Output below:

==================================== test session starts =====================================
platform linux -- Python 3.10.6, pytest-7.2.2, pluggy-1.0.0
rootdir: /home/jpm_pop/workspace/testing/MCDC, configfile: pytest.ini
collected 40 items                                                                           

test/regression/eigenvalue/2d_c5g7/test_1.py .                                         [  2%]
test/regression/eigenvalue/inf_shem361/test.py .                                       [  5%]
test/regression/eigenvalue/slab_2gu_iqmc/test.py F                                     [  7%]
test/regression/eigenvalue/slab_kornreich/test.py F                                    [ 10%]
test/regression/eigenvalue/slab_kornreich_iqmc/test.py F                               [ 12%]
test/regression/eigenvalue/smrg7/test.py F                                             [ 15%]
test/regression/fixed_source/C5G7-TDX/test.py F                                        [ 17%]
test/regression/fixed_source/C5G7-TDX/test_2.py F                                      [ 20%]
test/regression/fixed_source/azurv1_pl_super/test.py F                                 [ 22%]
test/regression/fixed_source/cooper2/test.py F                                         [ 25%]
test/regression/fixed_source/cooper2_iqmc/test.py F                                    [ 27%]
test/regression/fixed_source/dsm_azurv1/test.py F                                      [ 30%]
test/regression/fixed_source/dsm_lattice/test.py F                                     [ 32%]
test/regression/fixed_source/inf_casmo70/test.py F                                     [ 35%]
test/regression/fixed_source/inf_casmo70_td/test.py F                                  [ 37%]
test/regression/fixed_source/kobayashi3TD/test.py F                                    [ 40%]
test/regression/fixed_source/reed/test.py F                                            [ 42%]
test/regression/fixed_source/reed_iqmc/test.py F                                       [ 45%]
test/regression/fixed_source/slab_absorbium/test.py F                                  [ 47%]
test/regression/fixed_source/slab_isobeam_td/test.py F                                 [ 50%]
test/regression/fixed_source/slab_moving/test.py F                                     [ 52%]
test/unit/test_input_.py ........                                                      [ 72%]
test/unit/test_kernel.py .                                                             [ 75%]
test/unit/test_loop.py ...                                                             [ 82%]
test/unit/test_surface.py .                                                            [ 85%]
test/unit/test_type_.py ......                                                         [100%]

Copy link
Copy Markdown
Member

@ilhamv ilhamv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea! But, does it pass the tests? Also, did you make sure that it runs in Numba mode as well @goodman17c ?

Copy link
Copy Markdown
Member

@ilhamv ilhamv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes the tests and runs on Numba mode

@ilhamv ilhamv merged commit 40ef4f1 into mcdc-project:main May 17, 2023
clemekay pushed a commit to clemekay/MCDC that referenced this pull request Nov 2, 2023
melekderman pushed a commit to melekderman/MCDC that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants