Skip to content

Conversation

@moonorblue
Copy link

I add some essential import modules and update constants in README, to make the sample code up-to-date with this wrapper :)

@jaggedsoft
Copy link

Thank you for your contribution. Looks good to me, though we might need to specify how to get open orders instead of just trade history.

@jaggedsoft
Copy link

instead if import Decimal I had to do this

from decimal import *

@moonorblue
Copy link
Author

import Decimal

It was a typo in my previous commit, I think from decimal import Decimal should work :)

@moonorblue
Copy link
Author

moonorblue commented Jun 8, 2019

Thank you for your contribution. Looks good to me, though we might need to specify how to get open orders instead of just trade history.

I think the original READEME should be clear with the example open_orders = client.get_open_orders('tbnb185tqzq3j6y7yep85lncaz9qeectjxqe5054cgn') ,
And trade history should be clear in the comment I updated in commit e0c93 ?

@sammchardy sammchardy merged commit b2bfb34 into mchardysam:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants