Skip to content

Polish chat attachment UX#26

Merged
mcintyre94 merged 3 commits intomcintyre94:mainfrom
zmanian:pr/attachment-ux-polish
Mar 4, 2026
Merged

Polish chat attachment UX#26
mcintyre94 merged 3 commits intomcintyre94:mainfrom
zmanian:pr/attachment-ux-polish

Conversation

@zmanian
Copy link
Copy Markdown
Contributor

@zmanian zmanian commented Feb 28, 2026

Summary

  • Replace confirmationDialog with inline Menu on the attachment button for faster, less disruptive interaction
  • Add attachment chips view -- files appear as removable capsules above the input bar instead of raw paths in the text field
  • Show brief upload success feedback (green checkmark + filename, auto-clears after 2s)
  • Change file browser loading label from "Loading..." to "Connecting to sprite..." for better cold-start context
  • Convert SpriteFileBrowserView from @Binding selectedPath to onFileSelected callback
  • Fix duplicate PendingUserBubbleView entry in project file

Test plan

  • Tap "+" on chat input -- menu pops up inline (not slide-up action sheet)
  • Browse sprite files and select one -- chip appears above input bar, no raw path in text field
  • Upload a photo -- chip appears, brief green checkmark shows filename then fades
  • Tap "x" on a chip -- chip is removed
  • Send a message with chips attached -- message includes file paths + text, chips clear
  • Open file browser on a cold sprite -- shows "Connecting to sprite..."
  • Unit tests pass (185 tests, including FileEntryTests)

🤖 Generated with Claude Code

@zmanian zmanian force-pushed the pr/attachment-ux-polish branch 2 times, most recently from 283bee9 to bd28903 Compare March 1, 2026 00:13
@mcintyre94 mcintyre94 force-pushed the pr/attachment-ux-polish branch from bd28903 to 6c299b7 Compare March 1, 2026 23:38
@zmanian zmanian force-pushed the pr/attachment-ux-polish branch from 6c299b7 to 94897d3 Compare March 2, 2026 00:27
@mcintyre94
Copy link
Copy Markdown
Owner

This is an awesome UX improvement, thankyou! Love this, great idea!

zmanian and others added 3 commits March 4, 2026 22:51
- Replace confirmationDialog with inline Menu on attachment button
- Add AttachedFile model and attachment chips view instead of raw paths
- Show removable capsule chips above input bar for pending attachments
- Add upload success feedback with auto-clearing filename indicator
- Convert SpriteFileBrowserView from binding to callback pattern
- Change file browser loading label to "Connecting to sprite..."
- Fix duplicate PendingUserBubbleView entry in project file

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Store queued text and attachments separately so the pending bubble shows
nice attachment chips instead of raw file paths. Defer prompt building to
send time via buildPrompt(). Make AttachmentChipsView's remove button
optional so it can be reused read-only in the pending bubble.

For image attachments, the built prompt now includes a hint telling Claude
Code to use its Read tool to view the image, enabling multimodal support
without native CLI image input.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mcintyre94 mcintyre94 force-pushed the pr/attachment-ux-polish branch from 29b2bc5 to 23633a6 Compare March 4, 2026 23:16
@mcintyre94 mcintyre94 merged commit 7aa0369 into mcintyre94:main Mar 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants