fix: Resolve crash and project creation warnings#84
Merged
Conversation
This commit delivers a consolidated fix for two critical issues: 1. An `AttributeError` crash in the `DynamicNodeEditor`. 2. "File not found" warnings during new project creation. The `AttributeError` was caused by an incorrect attempt to call a non-existent `.destroy()` method on a widget. This has been corrected to use the proper GTK method, `parent.remove(child)`, to safely remove the widget from its container, resolving the crash. The "file not found" warnings were caused by an incomplete `create_project` method. This has been fixed by: - Adding all required headers to the `CharacterData.csv` file. - Ensuring that all necessary JSON data files are created with empty lists `[]` upon project initialization. - Adding checks to prevent overwriting existing files when a project template is used. This comprehensive solution ensures the application is stable and that new projects are created with a complete and valid data structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit delivers a consolidated fix for two critical issues:
AttributeErrorcrash in theDynamicNodeEditor.The
AttributeErrorwas caused by an incorrect attempt to call a non-existent.destroy()method on a widget. This has been corrected to use the proper GTK method,parent.remove(child), to safely remove the widget from its container, resolving the crash.The "file not found" warnings were caused by an incomplete
create_projectmethod. This has been fixed by:CharacterData.csvfile.[]upon project initialization.This comprehensive solution ensures the application is stable and that new projects are created with a complete and valid data structure.