Adds `SwarmVideoResampleFPS`; resamples controlnet preview videos by jtreminio · Pull Request #1387 · mcmonkeyprojects/SwarmUI

jtreminio · 2026-05-20T03:48:30Z

Adds new Comfy node SwarmVideoResampleFPS, which allows resampling videos FPS to a target FPS.

mcmonkey4eva · 2026-05-20T05:59:48Z

+
+class SwarmVideoResampleFPS(io.ComfyNode):
+    MIN_FPS: float = 1.0
+    MAX_FPS: float = 120.0


general rule for comfy inputs range limits is go way wider than seems sane. Never know when somebody's gonna complain about the lat of support for their 640 fps input video.

Copied from the CreateVideo node. I'll bump it to 1000? Doesn't seem like it would be valid down the chain though.

edit: ah, for input. For output the CreateVideo node would max out at 120fps.

Do you want a 1000 max input, and 120 max output?

I want this node to not be the node in the chain that breaks things and need to be edited to accommodate.

mcmonkey4eva · 2026-05-20T06:00:13Z

+            description="Resample a video from fps_in to fps_out while preserving total duration.",
+            inputs=[
+                io.Image.Input(
+                    "images",


very unnecessary linesplits

Changed, but imho split lines for more than 2 parameters is vastly more readable than having single lines except for something that should go in a single line:

io.Image.Input("images", tooltip="The images to resample."), io.Float.Input("fps_in", min=cls.MIN_FPS, max=cls.MAX_FPS, step=cls.STEP_FPS, tooltip="Source frame rate."), io.Float.Input("fps_out", default=cls.DEFAULT_FPS_OUT, min=cls.MIN_FPS, max=cls.MAX_FPS, step=cls.STEP_FPS, tooltip="Target frame rate."), io.Combo.Input("method", options=[cls.METHOD_LINEAR, cls.METHOD_NEAREST], default=cls.METHOD_LINEAR, tooltip=( "linear: each output frame is a linear blend of the two source frames bracketing its timestamp. " "Equivalent to ffmpeg's framerate filter. Slightly more expensive; avoids the duplicated-frame artifact. " "See https://ffmpeg.org/ffmpeg-filters.html#framerate\n" "nearest: each output frame is the source frame closest in time. " "Equivalent to ffmpeg's fps filter. Cheap; can produce visible judder on pans. " "See https://ffmpeg.org/ffmpeg-filters.html#fps-1" ), ),

writing( like, this, is awful )

and I can't understand why you'd do it. It's significantly less readable to my eyes.
io.Image.Input("images", tooltip="The images to resample."), is "Here's an input, it's images type with this tooltip text", perfect and simple
whereas the multiline split goes into the mode of "here's a wall of unstructured data, skip it unless/until you're willing to spend 5 minutes parsing a wall of data"

mcmonkey4eva · 2026-05-20T06:02:29Z

+        return io.NodeOutput(resampled, float(fps_out))
+
+    @classmethod
+    def _source_positions(cls, frame_count_out: int, fps_in: float, fps_out: float, device: torch.device) -> torch.Tensor:


there's more function body here than code, for a function used only once. This is "looks proper" code that's actually quite messy.

I'm going to ask you to reconsider this specific comment, but changing it pending.

_source_positions() could be boiled down to a single line:

return torch.arange(frame_count_out, dtype=torch.float64, device=device) / fps_out * fps_in

but then anyone not familiar with this functionality will read this as a foreign language. Yes it makes sense to you and I, but I'm going to take a minute or two in a year to understand what's going on. Anyone new to this whole world of 1girl will not understand what this line is actually doing.

Nobody who is lacking the tools to decipher what source_positions means or what a torch.arange is going to understand either version of this code, before or after.

You can leave a # comment explaining in one line what it is, maybe an example of inputs -> outputs, that much can help clarify.

mcmonkey4eva · 2026-05-20T06:02:56Z

+            resampled = cls._sample_linear(images, source_positions)
+
+        logger.info(
+            "SwarmVideoResampleFPS: %d frames @ %s fps -> %d frames @ %s fps (%s)",


why would you do this in a world where f strings exist

Force of habit from enterprise logging libs 👍

mcmonkey4eva · 2026-05-20T20:14:12Z

+class SwarmVideoResampleFPS(io.ComfyNode):
+    MIN_FPS: float = 1.0
+    MAX_FPS_IN: float = 1000.0
+    MAX_FPS_OUT: float = 120.0


this split is silly, just allow [0.01, 99999] there's no reason to have strict range limits anywhere here except creating future edge case bugs to fix

mcmonkey4eva · 2026-05-20T20:14:35Z

+                        "Equivalent to ffmpeg's framerate filter. Slightly more expensive; avoids the duplicated-frame artifact. "
+                        "See https://ffmpeg.org/ffmpeg-filters.html#framerate\n"
+                        "nearest: each output frame is the source frame closest in time. "
+                        "Equivalent to ffmpeg's fps filter. Cheap; can produce visible judder on pans. "


weird line splits here

mcmonkey4eva · 2026-05-20T20:14:44Z

+            ],
+            outputs=[
+                io.Image.Output("images"),
+                io.Float.Output("fps"),


unnecessary line splits

mcmonkey4eva · 2026-05-21T04:52:32Z

                    {
                        ["video"] = NodePath(result, 0)
                    });
+                    NodeHelpers["video_components_split"] = splitNode;


This method of forwarding data is liable to get mixed up from a different load call in the same workflowgen

Should I add a new property to WGNodeData? SourceFPSNode or similar?

Probably change public int? FPS = null; to a JToken that can either be a raw value or a node path ref

mcmonkey4eva · 2026-05-23T23:21:56Z

+                    ),
+                ),
+            ],
+            outputs=[io.Image.Output("images"), io.Float.Output("fps")],


second out is redundant, just returns an input

mcmonkey4eva · 2026-05-23T23:22:03Z

+                                ["method"] = "linear"
+                            });
+                            imageNodeActual = imageNodeActual.WithPath([resampleNode, 0]);
+                            imageNodeActual.FPS = 24;


hardcoded 24 is weird

mcmonkey4eva · 2026-05-23T23:22:31Z

                            ["scale_method"] = "lanczos"
                        });
                        imageNodeActual = imageNodeActual.WithPath([multipleOf8, 0]);
+                        if (imageNodeActual.DataType == WGNodeData.DT_VIDEO && imageNodeActual.FPS is not null)


wrong order of operations, this should be before preproc

mcmonkey4eva · 2026-05-23T23:22:52Z

                    g.CurrentMedia = g.CurrentMedia.WithPath(interp);
                    videoFps *= mult;
-                    g.CurrentMedia.FPS = videoFps;
+                    g.CurrentMedia.FPS = videoFps.HasValue ? videoFps.Value : null;


just bad edit

Adds SwarmVideoResampleFPS; resamples controlnet preview videos

d05d3d9

jtreminio force-pushed the controlnet-fps branch from 27171c9 to d05d3d9 Compare May 20, 2026 03:49

mcmonkey4eva reviewed May 20, 2026

View reviewed changes

jtreminio added 3 commits May 20, 2026 08:15

PR feedback

7a3980a

Collapse _source_positions()

0576695

Splits MAX_FPS_IN and MAX_FPS_OUT

3daccb1

jtreminio marked this pull request as ready for review May 20, 2026 13:26

Formatting

66c8ea9

mcmonkey4eva reviewed May 20, 2026

View reviewed changes

jtreminio added 2 commits May 20, 2026 15:55

Code review feedback

be41b85

Lower MIN_FPS

6d55625

mcmonkey4eva reviewed May 21, 2026

View reviewed changes

jtreminio added 2 commits May 22, 2026 23:47

Merge branch 'master' into controlnet-fps

a0e0b09

PR feedback: FPS to JToken; breaking change

a7b29bb

mcmonkey4eva reviewed May 23, 2026

View reviewed changes

fixes

32daf91

mcmonkey4eva merged commit 8718623 into mcmonkeyprojects:master May 23, 2026
2 of 3 checks passed

Uh oh!

Conversation

jtreminio commented May 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtreminio May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtreminio May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jtreminio May 20, 2026 •

edited

Loading

jtreminio May 20, 2026 •

edited

Loading