Skip to content

Conversation

@jtquach1
Copy link
Contributor

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

  • Added environment variables
  • Support sending ETASU check to rems-intermediary and keep support for sending to rems-admin via environment variables
  • Updated package-lock.json (used Node v21.7.3)

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/browse/REMS-712

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 requested a review from plarocque4 July 30, 2024 17:34
@plarocque4
Copy link
Contributor

This is much improved and works well, just address the last comment from above please.

@jtquach1
Copy link
Contributor Author

This is much improved and works well, just address the last comment from above please.

Done!

@plarocque4
Copy link
Contributor

Acetaminophen has no REMS but I am unable to verify the order, must be something wrong with ETASU checking on a drug with no ETASU/REMS?

@jtquach1
Copy link
Contributor Author

jtquach1 commented Aug 5, 2024

Acetaminophen has no REMS but I am unable to verify the order, must be something wrong with ETASU checking on a drug with no ETASU/REMS?

Fixed in fd2bc80!

Copy link
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@plarocque4 plarocque4 merged commit ec8c6c0 into dev Aug 5, 2024
@plarocque4 plarocque4 deleted the update-etasu-check-to-use-intermediary branch August 5, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants