Skip to content

[REMS-97] PR template to master #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smalho01 merged 4 commits into from
Feb 7, 2022
Merged

[REMS-97] PR template to master #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3b9bf4
Adding PR template
kierk Feb 3, 2022
c44cb40
Merge pull request #10 from mcode/pr-template
kierk Feb 3, 2022
a8361d0
ci pipeline hot fix
smalho01 Feb 3, 2022
1dfe3ed
Merge pull request #12 from mcode/ci-cd-fix
smalho01 Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Check these steps before issuing the PR:
- [] Ensure the target / base branch for any feature PR is set to `dev` not master (the only exception to this is releases from `dev` and hotfix branches)
- [] Please make sure your PR Title is of the following syntax: `[REMS-##] Short Issue Name` if ready for review
2 changes: 1 addition & 1 deletion .github/workflows/docker-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Docker Image CI

on:
pull_request:
branches: [ master ]
branches: [ master, dev ]
workflow_dispatch:


Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/porter-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Porter Invocation Docker Image CI

on:
pull_request:
branches: [ master ]
branches: [ master, dev ]
workflow_dispatch:


Expand All @@ -14,6 +14,11 @@ jobs:
- name: Checkout Repository
uses: actions/checkout@v2

- run: 'echo "VSAC_API_KEY=$VSAC_API_KEY" > .env; echo "COMPOSE_PROJECT_NAME=rems_porter" >> .env'
shell: bash
env:
VSAC_API_KEY: ${{secrets.VSAC_API_KEY}}

- name: Install Porter
run: curl -L https://cdn.porter.sh/canary/install-linux.sh | bash

Expand Down