-
Notifications
You must be signed in to change notification settings - Fork 2
732 rems admin UI #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
732 rems admin UI #157
Conversation
|
This UI looks and functions great. It would be nice to have a different banner color from the other apps though. |
|
It would also be nice to have the status just show a met requirements column only show the status like the ETASU status buttons and would then have a popup that shows the full etasu status when clicked on. This is likely too much work for this set of issues, we should write a new ticket for this change. |
|
There should be some info on starting the frontend in the README as well |
|
Can you also make it so the frontend runs with the same command as all the others, 'nom start' ? |
plarocque4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!

Describe your changes
Added react application for rems admin ui. Start the UI from the /frontend folder with
npm run dev(I still have to update docker stuff to start it when running docker and update the hard coded URLs to use env variables).Test the following functionality -
Issue ticket number and Jira link
https://jira.mitre.org/browse/REMS-734 https://jira.mitre.org/browse/REMS-732 https://jira.mitre.org/browse/REMS-733
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.