Skip to content

Conversation

@avirgulto
Copy link
Contributor

Describe your changes

Added react application for rems admin ui. Start the UI from the /frontend folder with npm run dev (I still have to update docker stuff to start it when running docker and update the hard coded URLs to use env variables).

Test the following functionality -

  • Added Login with keycloak, once logged in you can view the data. On page refresh or logout button will go back to login page. ( https://jira.mitre.org/browse/REMS-734)
  • 3 tabs with each of the data in the DB, there is a reset DB button which opens up dialog to double check user wants to reset full database. (REMS-732)
  • Clear single items. For rems case colleciton it will also clear out any patient questionnaire with that rems case. If there is a prescriber form it will remove the case number from the case we're deleting from that form. (https://jira.mitre.org/browse/REMS-733)
  • Added backend support for getting and deleting data.

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-734 https://jira.mitre.org/browse/REMS-732 https://jira.mitre.org/browse/REMS-733

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4
Copy link
Contributor

This UI looks and functions great. It would be nice to have a different banner color from the other apps though.

@plarocque4
Copy link
Contributor

It would also be nice to have the status just show a met requirements column only show the status like the ETASU status buttons and would then have a popup that shows the full etasu status when clicked on. This is likely too much work for this set of issues, we should write a new ticket for this change.

@plarocque4
Copy link
Contributor

The login page has an extra ';' underneath the sign in button. See the attached image.
Screenshot 2024-09-25 at 4 14 52 PM

@plarocque4
Copy link
Contributor

There should be some info on starting the frontend in the README as well

@plarocque4
Copy link
Contributor

Can you also make it so the frontend runs with the same command as all the others, 'nom start' ?

Copy link
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@plarocque4 plarocque4 merged commit 5fbd58d into dev Sep 26, 2024
@plarocque4 plarocque4 deleted the 732-rems-admin-ui branch September 26, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants