Skip to content

[REMS-268] Fix Porter#30

Merged
smalho01 merged 3 commits intomasterfrom
rems-268-migrate-porter-v0v1
Oct 31, 2022
Merged

[REMS-268] Fix Porter#30
smalho01 merged 3 commits intomasterfrom
rems-268-migrate-porter-v0v1

Conversation

@kennyEung
Copy link
Copy Markdown
Contributor

  • Added 'schemaVersion' to porter.yml as required by breaking changes from the porter v0 to v1 release.

Check these steps before issuing the PR:

  • [] Ensure the target / base branch for any feature PR is set to dev not master (the only exception to this is releases from dev and hotfix branches)
  • [] Please make sure your PR Title is of the following syntax: [REMS-##] Short Issue Name if ready for review

@kennyEung kennyEung marked this pull request as ready for review October 19, 2022 18:27
@kennyEung kennyEung marked this pull request as draft October 19, 2022 21:51
@kennyEung kennyEung marked this pull request as ready for review October 20, 2022 21:24
@kennyEung
Copy link
Copy Markdown
Contributor Author

@smalho01 Looking into it further, only the invocationImage field has been deprecated. Not the invocation image or creation of that image.

In otherwords, if our porter.yaml file had defined invocationImage: exampleTag, then we'd get a caution from Porter's linter stating: WARNING: The "invocationImage" field has been deprecated and can no longer be user-specified; ignoring. In which case we'd just have to delete the invocationImage field and its value. It also doesn't seem like we directly reference the invocation image's name anywhere in the workflow CI or CD files. So the pipelines should be good to go.

Screen Shot 2022-10-20 at 5 29 47 PM

Porter Migration Reference.

@smalho01 smalho01 merged commit 27d28e0 into master Oct 31, 2022
@smalho01 smalho01 deleted the rems-268-migrate-porter-v0v1 branch November 1, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants