Skip to content

REMS-292 adding linting and CI workflow to repository#37

Merged
smalho01 merged 4 commits intodevfrom
linting
Nov 18, 2022
Merged

REMS-292 adding linting and CI workflow to repository#37
smalho01 merged 4 commits intodevfrom
linting

Conversation

@rdingwell
Copy link
Copy Markdown
Contributor

@rdingwell rdingwell commented Nov 17, 2022

Describe your changes

This PR adds linting via eslint and prettier to the repository, adds npm scripts in package json to run those utilities and adds a github ci workflow to run linting and tests on pushes and pull requests.

Issue ticket number and Jira link

REMS 292

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@smalho01 smalho01 merged commit e17845a into dev Nov 18, 2022
@smalho01 smalho01 deleted the linting branch November 18, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants