REMS 257 - CDS Hooks#38
Merged
plarocque4 merged 4 commits intodevfrom Dec 6, 2022
Merged
Conversation
Contributor
|
The tests fail when running 'npm test'. |
3d0f4a3 to
e785ea3
Compare
Contributor
|
The tests still fail for me. |
Contributor
|
I'm guessing that the tests are failing because they are .js files attempting to include .ts files. I think all of the tests need to be converted over to typescript as well. I think this will also involve bringing in ts-jest and other supporting packages, which may also require tests to be moved into a test directory. |
plarocque4
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Along with some changes to support CDS hooks, this pull request refactors the REMS admin app to use typescript. Classes and interfaces are added to support the order-sign hook, and an example hook is included to allow basic testing of the process. To test, POST the example hook to the cds-service endpoint, and you should receive a card with relevant links/info. You can do the same process through the request generator, by modifying the settings to point at the CDS service. The returned cards should display correctly and allow you to click through to the DTR app, though the SMART app can't launch without some sort of support on the REMS admin for returning the Questionnaire package.
Further work will include adding a FHIR server and making an endpoint to service requests for the questionnaires and their respective prepopulation CQL files.
Issue ticket number and Jira link
https://jira.mitre.org/browse/REMS-257
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review