Skip to content

REMS 257 - CDS Hooks#38

Merged
plarocque4 merged 4 commits intodevfrom
cds-hooks
Dec 6, 2022
Merged

REMS 257 - CDS Hooks#38
plarocque4 merged 4 commits intodevfrom
cds-hooks

Conversation

@KeeyanGhoreshi
Copy link
Copy Markdown
Contributor

@KeeyanGhoreshi KeeyanGhoreshi commented Nov 17, 2022

Describe your changes

Along with some changes to support CDS hooks, this pull request refactors the REMS admin app to use typescript. Classes and interfaces are added to support the order-sign hook, and an example hook is included to allow basic testing of the process. To test, POST the example hook to the cds-service endpoint, and you should receive a card with relevant links/info. You can do the same process through the request generator, by modifying the settings to point at the CDS service. The returned cards should display correctly and allow you to click through to the DTR app, though the SMART app can't launch without some sort of support on the REMS admin for returning the Questionnaire package.

Further work will include adding a FHIR server and making an endpoint to service requests for the questionnaires and their respective prepopulation CQL files.

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-257

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

@KeeyanGhoreshi KeeyanGhoreshi changed the base branch from main to dev November 17, 2022 20:53
@plarocque4
Copy link
Copy Markdown
Contributor

The tests fail when running 'npm test'.

@plarocque4
Copy link
Copy Markdown
Contributor

The tests still fail for me.

@rdingwell
Copy link
Copy Markdown
Contributor

I'm guessing that the tests are failing because they are .js files attempting to include .ts files. I think all of the tests need to be converted over to typescript as well. I think this will also involve bringing in ts-jest and other supporting packages, which may also require tests to be moved into a test directory.

@plarocque4 plarocque4 merged commit 1355f68 into dev Dec 6, 2022
@plarocque4 plarocque4 deleted the cds-hooks branch December 6, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants