Skip to content

Fix VSAC key environment variable#54

Merged
smalho01 merged 2 commits intodevfrom
standalone
Feb 21, 2023
Merged

Fix VSAC key environment variable#54
smalho01 merged 2 commits intodevfrom
standalone

Conversation

@plarocque4
Copy link
Copy Markdown
Contributor

Describe your changes

The environment vsac key variable for running standalone (outside of docker) needs to change. Log the error that occurs when failing to parse a fhir resource on load.

Issue ticket number and Jira link

none

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

…docker) needs to change. Log the error that occurs when failing to parse a fhir resource on load.
@KeeyanGhoreshi
Copy link
Copy Markdown
Contributor

no idea why the test is failing, but would approve this otherwise

smalho01
smalho01 previously approved these changes Feb 21, 2023
@smalho01
Copy link
Copy Markdown
Collaborator

do we want to fix the failing test case before merging @plarocque4 or should we just merge now? The changes look good to me

@smalho01 smalho01 merged commit b5388c1 into dev Feb 21, 2023
@smalho01 smalho01 deleted the standalone branch February 21, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants