Skip to content

Rems 326 mongoose etasu#59

Merged
smalho01 merged 10 commits intodevfrom
rems-326-mongoose-etasu
Mar 28, 2023
Merged

Rems 326 mongoose etasu#59
smalho01 merged 10 commits intodevfrom
rems-326-mongoose-etasu

Conversation

@kennyEung
Copy link
Copy Markdown
Contributor

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@smalho01
Copy link
Copy Markdown
Collaborator

smalho01 commented Mar 27, 2023

looks good, but is missing the mongoose api calls, will re-review once those are in

Comment thread src/fhir/utilities.ts Outdated
@smalho01 smalho01 mentioned this pull request Mar 28, 2023
4 tasks
@smalho01 smalho01 merged commit 8dcbb4d into dev Mar 28, 2023
@smalho01 smalho01 deleted the rems-326-mongoose-etasu branch March 28, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants