REMS-366: Fixing caching tests#65
Merged
plarocque4 merged 21 commits intodevfrom Apr 17, 2023
Merged
Conversation
…pdate to deal with failing tests
Reverting to node 14
Upping test timeout for github runners
plarocque4
reviewed
Apr 5, 2023
plarocque4
reviewed
Apr 5, 2023
plarocque4
previously approved these changes
Apr 17, 2023
plarocque4
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes issues related to running test suite in the github CI. The CI had stability and consistency issues running the tests, especially on the Mac OS. All of the issues tracked to being problems with the jest testing framework. To resolve these issues the tests were migrated to mocha.
Issue ticket number and Jira link
REMS-366
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.