Skip to content

hot fix for docker install#67

Merged
kennyEung merged 5 commits intomainfrom
docker-config-updates
Apr 6, 2023
Merged

hot fix for docker install#67
kennyEung merged 5 commits intomainfrom
docker-config-updates

Conversation

@smalho01
Copy link
Copy Markdown
Collaborator

@smalho01 smalho01 commented Apr 6, 2023

Describe your changes

Hot fix for docker-compose configuration - this directly addresses #66. The volume names were mismatched for the mongo instance. Tested all 3 docker installs locally and all work. Need to merge this into main directly (will also update the 0.9 release accordingly just in case). Will then merge main into dev after to have the two branches consistent

Issue ticket number and Jira link

#66

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@kennyEung
Copy link
Copy Markdown
Contributor

Reviewed. No more undefined docker volume errors.

kennyEung
kennyEung previously approved these changes Apr 6, 2023
@kennyEung kennyEung dismissed their stale review April 6, 2023 17:25

Other images are running on AMD64

@kennyEung
Copy link
Copy Markdown
Contributor

kennyEung commented Apr 6, 2023

I actually un-approved it 😅. Many of the images in dockerHub codexrems were built using amd64 not arm64.

Screenshot 2023-04-06 at 1 28 43 PM

So we probably need to push those images as well as update the docker-compose again. There are no crashes with the amd64 images (so far), but performance is abysmal.

@kennyEung
Copy link
Copy Markdown
Contributor

Performance issues related to amd64 images will be addressed in the next release.

@kennyEung kennyEung merged commit f61ae72 into main Apr 6, 2023
@kennyEung kennyEung deleted the docker-config-updates branch April 6, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants