Skip to content

Update Developer Setup Guide to include instructions on pulling submodules.#69

Merged
smalho01 merged 4 commits intodevfrom
prefetch-submodule
Apr 27, 2023
Merged

Update Developer Setup Guide to include instructions on pulling submodules.#69
smalho01 merged 4 commits intodevfrom
prefetch-submodule

Conversation

@plarocque4
Copy link
Copy Markdown
Contributor

@plarocque4 plarocque4 commented Apr 7, 2023

Describe your changes

Update Developer Setup Guide to include instructions on pulling submodules.

Issue ticket number and Jira link

REMS-369

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

smalho01
smalho01 previously approved these changes Apr 10, 2023
@smalho01 smalho01 self-assigned this Apr 10, 2023
Copy link
Copy Markdown
Contributor

@KeeyanGhoreshi KeeyanGhoreshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can ignore the failing tests for now since the switch to mocha should take care of the strange errors jest is giving.

When I pulled the submodule I had to run git submodule update --remote after the init to actually get the submodule on the branch I wanted it to be on. I think it might also be helpful to add a note about troubleshooting, since I had to use https to get it to run with git submodule sync.

@smalho01 smalho01 merged commit a9bd92f into dev Apr 27, 2023
@smalho01 smalho01 deleted the prefetch-submodule branch April 27, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants