Conversation
…pdate to deal with failing tests
…for use of any, updated lint rules to allow for unused variables prepended with _
…ine with a single approach to asynchronous activities
kennyEung
previously approved these changes
Apr 17, 2023
KeeyanGhoreshi
requested changes
Apr 18, 2023
Contributor
KeeyanGhoreshi
left a comment
KeeyanGhoreshi
left a comment
There was a problem hiding this comment.
The ReadMe should be updated to include any additional setup steps for running locally. As it is now, the setup process won't work until you add a username/password for the mongo DB in your environment.
…hronous versions. Adding npm glob package to streamline processing of resources to load from filesystem. Adding tests for populateDB and loadResource functions
KeeyanGhoreshi
previously approved these changes
Apr 21, 2023
Contributor
KeeyanGhoreshi
left a comment
KeeyanGhoreshi
left a comment
There was a problem hiding this comment.
Works as expected, just one minor nitpick, still good for approval regardless.
KeeyanGhoreshi
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR removes most Promises from the application and replaces them with async/await functions. Included in the PR is bare minimum tests for the service classes.
Upon testing issues were found with the QuestionnaireResponse schema models. The cause was due to the circular nature of the previous definitions where QuestionnaireResponse_Item included and used QuestionnaireResponse_Answer which included and used QuestionnaireResponse_Item. To resolve the issues the schemas where modified to augment the QuestionnaireResponse_Answer schema in the QuestionnaireResponse_Item scheme file. There may be other schemas that need to be modified similarly.
mocha configuration was moved to the .mocharc.json file. Global mongo test server instantiation was added via mocha pre hooks that run before the test suites are run.
Issue ticket number and Jira link
Please include the Jira Ticket Number and Link for this issue/task.
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.