Skip to content

moving hardcoded values to env.json file#75

Merged
plarocque4 merged 3 commits intodevfrom
remove_hardcoded_values
May 4, 2023
Merged

moving hardcoded values to env.json file#75
plarocque4 merged 3 commits intodevfrom
remove_hardcoded_values

Conversation

@rdingwell
Copy link
Copy Markdown
Contributor

Describe your changes

Moving additional hardcoded values to env.json file so they can be configured via environment variables for different deployments

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

Copy link
Copy Markdown
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@plarocque4 plarocque4 merged commit 853fbdf into dev May 4, 2023
@plarocque4 plarocque4 deleted the remove_hardcoded_values branch May 4, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants