Skip to content

Cds hooks type#29

Merged
smalho01 merged 4 commits intodevfrom
cds-hooks-type
Sep 30, 2024
Merged

Cds hooks type#29
smalho01 merged 4 commits intodevfrom
cds-hooks-type

Conversation

@smalho01
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread resources/HookTypes.ts

export interface TypedRequestBody extends Express.Request {
body: Hook;
body: any;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this to any? Is this meant to be a temporary change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was causing issues with the intermediary. Then it was causing issues with REMS Admin when I fixed that. Keeping it as any gets it to work with everything. Its an issue with the type inheritance not the functionality itself

@smalho01 smalho01 merged commit 1071035 into dev Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants