Merged
Conversation
88081da to
24c30f6
Compare
kennyEung
approved these changes
Jan 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
In support of REMS-260, this PR removes the
requestelement from the prefetch in order to comply with the CDS hooks specification. You can read about prefetch tokens here:https://cds-hooks.hl7.org/1.0/#prefetch-tokens
The request prefetch token is not valid due to the following rule:
In order to use the MedicationRequest id as a prefetch token, it would need to be a top-level element of the
contextso that it could be accessed withcontext.medicationRequestId.Since we do not know what the prefetch will look like for our purposes, I've removed this part of the prefetch entirely for now. Once the REMS CRD app starts requiring information in the prefetch, we will have a better understanding of what belongs in our prefetch and can make the appropriate changes at that time.
Issue ticket number and Jira link
REMS-260
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.