Conversation
…add support for version 2017071.
|
Looks good and works for me on my end thanks for making these changes. Could you also update the pims endpoint to hit "http://localhost:5051/doctorOrders/api/addRx" as the default? I apologize for changing it last minute |
zacharyrobin
approved these changes
Feb 9, 2023
zacharyrobin
left a comment
There was a problem hiding this comment.
Tested all 3 drugs, works on my end and integrates nicely with the PIMS system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update the NCPDP SCRIPT NewRx message sent to PIMS to include the necessary required fields. The code has been split out into a separate file, and another version for the currently used version of SCRIPT (2017071) has been created as well. These changes should be tested with the changes to the test-ehr on the required-fields branch.
Issue ticket number and Jira link
REMS-309
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.