Skip to content

[REMS-309] Update NCPDP SCRIPT NewRx#33

Merged
smalho01 merged 3 commits intodevfrom
required-fields
Feb 9, 2023
Merged

[REMS-309] Update NCPDP SCRIPT NewRx#33
smalho01 merged 3 commits intodevfrom
required-fields

Conversation

@plarocque4
Copy link
Copy Markdown

Describe your changes

Update the NCPDP SCRIPT NewRx message sent to PIMS to include the necessary required fields. The code has been split out into a separate file, and another version for the currently used version of SCRIPT (2017071) has been created as well. These changes should be tested with the changes to the test-ehr on the required-fields branch.

Issue ticket number and Jira link

REMS-309

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@zacharyrobin
Copy link
Copy Markdown

Looks good and works for me on my end thanks for making these changes. Could you also update the pims endpoint to hit "http://localhost:5051/doctorOrders/api/addRx" as the default? I apologize for changing it last minute

Copy link
Copy Markdown

@zacharyrobin zacharyrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all 3 drugs, works on my end and integrates nicely with the PIMS system.

@smalho01 smalho01 merged commit 5bb54b2 into dev Feb 9, 2023
@smalho01 smalho01 deleted the required-fields branch February 9, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants