Skip to content

504 & 505 patient select UI updates and hiding empty state#52

Merged
plarocque4 merged 6 commits intodevfrom
504-patient-select-ui-updates
Sep 8, 2023
Merged

504 & 505 patient select UI updates and hiding empty state#52
plarocque4 merged 6 commits intodevfrom
504-patient-select-ui-updates

Conversation

@avirgulto
Copy link
Copy Markdown

Describe your changes

Updates to the patient select button, hiding fields and buttons when no patient is selected, added in a 'empty' state vs N/A when there is no data, rename some of the button names, disabled the 'open in-progress forms' button if no form is selected, and change button for open developer console instead of +.

To test:
Load the request generator, see all visual changes on initial load when no patient is selected. Select a patient without a medication. See the buttons and information show, with the appropriate buttons disabled. Then load the patient with medication and see the other buttons enabled as well as some more information filled in. Then go through and get an in progress form. Open up an in progress form and see the 'open in-progress form' button is enabled.

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-504 and https://jira.mitre.org/browse/REMS-505

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

Copy link
Copy Markdown

@jtquach1 jtquach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me, with some minor comments. Should we include tests or is that something @afeinman-mitre is working on that we could add later on?

Comment thread src/components/ConsoleBox/consoleBox.css Outdated
Comment thread src/components/RequestBox/RequestBox.js Outdated
Comment thread src/containers/RequestBuilder.js Outdated
Comment thread src/containers/RequestBuilder.js Outdated
Comment thread src/containers/RequestBuilder.js
@avirgulto avirgulto requested a review from jtquach1 September 8, 2023 14:25
@avirgulto
Copy link
Copy Markdown
Author

I think this looks good to me, with some minor comments. Should we include tests or is that something @afeinman-mitre is working on that we could add later on?

Yeah i think once the testing is merged into develop and stuff, we can definitely add a small test for the new workflow of hidden and disabled things! I'll make a ticket in the backlog for this!

@plarocque4
Copy link
Copy Markdown

I like how the prefetched area disappears when the in-progress form is selected. Could we do the same with the In Progress Form area? Could it only be visible with a selected in progress form and hide otherwise?

Copy link
Copy Markdown

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@plarocque4 plarocque4 merged commit 01ad727 into dev Sep 8, 2023
@plarocque4 plarocque4 deleted the 504-patient-select-ui-updates branch September 8, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants