504 & 505 patient select UI updates and hiding empty state#52
504 & 505 patient select UI updates and hiding empty state#52plarocque4 merged 6 commits intodevfrom
Conversation
…d removing toggles
…uttons, show empty state
jtquach1
left a comment
There was a problem hiding this comment.
I think this looks good to me, with some minor comments. Should we include tests or is that something @afeinman-mitre is working on that we could add later on?
Yeah i think once the testing is merged into develop and stuff, we can definitely add a small test for the new workflow of hidden and disabled things! I'll make a ticket in the backlog for this! |
|
I like how the prefetched area disappears when the in-progress form is selected. Could we do the same with the In Progress Form area? Could it only be visible with a selected in progress form and hide otherwise? |
Describe your changes
Updates to the patient select button, hiding fields and buttons when no patient is selected, added in a 'empty' state vs N/A when there is no data, rename some of the button names, disabled the 'open in-progress forms' button if no form is selected, and change button for open developer console instead of +.
To test:
Load the request generator, see all visual changes on initial load when no patient is selected. Select a patient without a medication. See the buttons and information show, with the appropriate buttons disabled. Then load the patient with medication and see the other buttons enabled as well as some more information filled in. Then go through and get an in progress form. Open up an in progress form and see the 'open in-progress form' button is enabled.
Issue ticket number and Jira link
https://jira.mitre.org/browse/REMS-504 and https://jira.mitre.org/browse/REMS-505
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.