Skip to content

Add select button, conditionally show form dropdown#55

Merged
smalho01 merged 1 commit intodevfrom
509-patient-select-row
Sep 12, 2023
Merged

Add select button, conditionally show form dropdown#55
smalho01 merged 1 commit intodevfrom
509-patient-select-row

Conversation

@avirgulto
Copy link
Copy Markdown

Describe your changes

Add a select button to each patient row. If no data, don't show dropdown and show label saying 'no in-progress forms". Added a refresh button next to the in progress forms to allow for a refresh when the patient select modal is open. Update language of medication in dropdown once selected, it adds medication request number after the name of medication now. The open in-progress form button now is enabled at any point when there is a in progress form loaded in.

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-509

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

Copy link
Copy Markdown

@zacharyrobin zacharyrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forms look great, I really like the new layout. Few bugs noted:

  1. Drop down for in progress form automatically selects a form even if you dont click on it. If you just view the drop down it seems to auto select the first one.

  2. if you switch to a different medication the drop down for in progress forms wont clear unless you close out patient select window.

Screenshot 2023-09-12 at 9 55 39 AM

@avirgulto
Copy link
Copy Markdown
Author

Forms look great, I really like the new layout. Few bugs noted:

  1. Drop down for in progress form automatically selects a form even if you dont click on it. If you just view the drop down it seems to auto select the first one.
  2. if you switch to a different medication the drop down for in progress forms wont clear unless you close out patient select window.

Screenshot 2023-09-12 at 9 55 39 AM

Yeah I think these were existing bugs that I had noticed before but didn't spend that much time trying to fix, I'll relook at these and hopefully can update it quickly!

@zacharyrobin
Copy link
Copy Markdown

Forms look great, I really like the new layout. Few bugs noted:

  1. Drop down for in progress form automatically selects a form even if you dont click on it. If you just view the drop down it seems to auto select the first one.
  2. if you switch to a different medication the drop down for in progress forms wont clear unless you close out patient select window.

Screenshot 2023-09-12 at 9 55 39 AM

Yeah I think these were existing bugs that I had noticed before but didn't spend that much time trying to fix, I'll relook at these and hopefully can update it quickly!

Its not a major issue, if its gonna be a lot more work then Id say we can log it and come back to it for the next release.

@smalho01 smalho01 merged commit 569ddb4 into dev Sep 12, 2023
@smalho01 smalho01 deleted the 509-patient-select-row branch September 12, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants