Conversation
avirgulto
previously approved these changes
Oct 2, 2023
avirgulto
left a comment
avirgulto
left a comment
There was a problem hiding this comment.
Dropdown worked as expected, everything looks good.
KeeyanGhoreshi
force-pushed
the
package-update
branch
from
65ad7c4 to
368965a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes semantic UI from the request generator and replaces it with an equivalent in Material UI. Also, packages have been updated to deal with peer dependency issues with material UI and our version of React, material UI updated as well, and various imports updated.
The UI could maybe use a touch up after the switch, since the drop downs now contain the information in a less readable way, but that can be a separate task.
Issue ticket number and Jira link
REMS-516
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review