Skip to content

Remove deidentify coverage checkbox and related code#62

Merged
plarocque4 merged 3 commits intodevfrom
remove-deidentify-checkbox
Sep 27, 2023
Merged

Remove deidentify coverage checkbox and related code#62
plarocque4 merged 3 commits intodevfrom
remove-deidentify-checkbox

Conversation

@jtquach1
Copy link
Copy Markdown

@jtquach1 jtquach1 commented Sep 26, 2023

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

Removed "Deidentify coverage" checkbox and related code, untracked src/db.json (doing gim rm), and updated package-lock.json.

image

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/browse/REMS-506

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 force-pushed the remove-deidentify-checkbox branch from 3af272a to 3ff2555 Compare September 26, 2023 21:34
@jtquach1 jtquach1 force-pushed the remove-deidentify-checkbox branch from 3ff2555 to 2ad9ca8 Compare September 26, 2023 22:51
@jtquach1 jtquach1 requested a review from plarocque4 September 26, 2023 22:52
@jtquach1 jtquach1 marked this pull request as ready for review September 26, 2023 22:54
Copy link
Copy Markdown

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@plarocque4 plarocque4 merged commit f29758d into dev Sep 27, 2023
@plarocque4 plarocque4 deleted the remove-deidentify-checkbox branch September 27, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants