Skip to content

fixed the ehr url being sent to the rems admin#72

Merged
smalho01 merged 4 commits intodevfrom
fix-docker-ehr-url
Nov 29, 2023
Merged

fixed the ehr url being sent to the rems admin#72
smalho01 merged 4 commits intodevfrom
fix-docker-ehr-url

Conversation

@smalho01
Copy link
Copy Markdown
Collaborator

@smalho01 smalho01 commented Nov 7, 2023

Describe your changes

Fixed the issue of having the rems admin doing the prefetch not working in docker. To test, please run the following PRs all together in docker: mcode/rems-setup#17, mcode/rems-admin#119. Then in the settings panel for request generator uncheck the "Send Prefetch" option and send an order sign hook request to the rems admin.

Issue ticket number and Jira link

REMS-536

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@avirgulto
Copy link
Copy Markdown

I couldn't get it working with my docker setup, i was getting an error connecting to the rems-admin. I tried restarting my environment and stuff but it didn't seem to work! might be worth having someone else with docker test it out as well to see if it was just me or the branch

@jtquach1
Copy link
Copy Markdown

Leaving this here as an FYI- I did git checkout --theirs package-lock.json to use the changed package-lock.json on origin/dev rather than the one on this branch, since this branch was outdated with origin/dev.

Copy link
Copy Markdown

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as expected.

@smalho01 smalho01 merged commit b851fa8 into dev Nov 29, 2023
@smalho01 smalho01 deleted the fix-docker-ehr-url branch November 29, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants