chore: bump buffer to ^6.0.3 and bloomfilter to ^1.1.0#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buffer(runtime dep) from^5.2.1to^6.0.3.bloomfilter(devDep, used by the uniqueness test only) from^0.0.18to^1.1.0.Both are major-version jumps, which is why the existing caret ranges would not pick them up.
Test plan
npm run lintpassesnpm run typescriptpassestape test/test.js test/buffer.jspasses (buffer fallback path exercised via proxyquire)tape test/uniqueness.jspasses — 6/6 tests, 0 bloom-filter conflicts across ~2M generated ids (confirms thebloomfilter@1.xAPI is still compatible)