Fix stale pending user-input after session restart#4
Merged
Conversation
mcorrig4
added a commit
that referenced
this pull request
Mar 16, 2026
Co-authored-by: Liam C. (do-box) <liam@chaintail.xyz>
claude-do
added a commit
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This promotes the pending-question work we validated on dev.
AGENTS.mdRoot Cause
Pending user-input request IDs are session-local and live only in the original provider session's in-memory request map. After a service restart, the thread can still show the pending question in persisted activity state, but the original request ID is no longer answerable.
Before this change,
respondToUserInputallowed provider-session recovery, which made the server attempt to answer a stale request on a different session. That producedUnknown pending user input requestand left the thread stuck on the question UI.Fix
allowRecovery: falseforrespondToUserInputQuestion expiredtoast and restore access to normal chatValidation
bun fmtbun lintbun typecheckRelated