Skip to content

QWT#190

Merged
mcowger merged 1 commit intomainfrom
qt
Apr 16, 2026
Merged

QWT#190
mcowger merged 1 commit intomainfrom
qt

Conversation

@mcowger
Copy link
Copy Markdown
Owner

@mcowger mcowger commented Apr 16, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

PR Review: QWT (Deletion of auth.json.example, config-to-database.md, and index.ts comment)

This PR removes 572 lines across 3 files — an example auth file, a migration plan document, and a code comment. The deletions themselves are clean, but there are several dangling references that will break or confuse users if this merges as-is.

Issues Found

  1. Broken link in README.md (line 152) — References [config-to-database.md](config-to-database.md) which is being deleted by this PR. This will result in a dead link.

  2. Stale docs/CONFIGURATION.md — Still references auth.json.example (line 338: "An example file is provided at auth.json.example") and extensively documents auth.json usage (lines 333-385). If the example file and migration doc are being removed, these docs need updating too.

  3. Stale docs/INSTALLATION.md — Still references auth.json default path (line 115).

  4. Code still has auth.json import pathpackages/backend/src/services/config-service.ts contains importFromAuthJson() which reads the auth.json format. If the example file is being removed to deprecate auth.json, the import logic in code should also be addressed (or the example file should be kept until that code is removed).

  5. .gitignore still lists auth.json — Minor, but if the file is fully deprecated this entry could be cleaned up.

Summary

The core problem is partial deletion: the files are removed but nothing that references them is updated. The README will have a dead link, and the documentation still tells users to look for files that no longer exist. Either this PR should also update the references, or the deletions should be deferred until a coordinated cleanup.

@mcowger mcowger merged commit f981621 into main Apr 16, 2026
1 of 2 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 17, 2026
@mcowger mcowger deleted the qt branch April 17, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant