refactor: convert sampling from option to independent mode plugins #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new execution modes: agentic_sampling and agentic_workflow_sampling - Create dedicated mode plugins for sampling (mode-agentic-sampling-plugin.ts, mode-workflow-sampling-plugin.ts) - Create separate registrar functions for sampling modes - Remove sampling parameter from existing mode plugins and registrars - Update ComposeDefinition to use samplingConfig instead of sampling option - Simplify mode-specific logic by eliminating conditional sampling checks - Update examples to use new mode naming convention This refactor improves maintainability by: - Separating concerns: each mode has its own plugin - Eliminating confusing option/mode mixing - Making execution modes explicit and type-safe - Simplifying codebase by removing conditional branching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor improves maintainability by: