Small threading fix, delay to main thread#19
Merged
Conversation
Previously when calling a function on a worker thread and encountering a load error, pausing would trigger a exception as we use the Unity API on a worker thread. This is only for Lazy mode, where the thread safety is not yet fully implemented.
Owner
|
So maybe just extract the dispatching logic to sth like: |
Contributor
Author
|
Yes agreed. However, in the logic of the previous PR there's also an additional bool UnityNativeTool/scripts/DllManipulator.cs Lines 565 to 568 in f4eb21d I've left it as is in the previous PR (seeing as its only one occurrence) and changed it for these diffs. Or do you see an nice way of doing this? |
Owner
|
Yup I forgot about that flag there. You could do something like this but I don't see much sense in doing so so yes, leave this as is, whatever |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when calling a function on a worker thread and encountering a load error, setting the pause state would trigger a exception as we use the Unity API on a worker thread.
This is only for Lazy mode, where the thread safety is not yet fully implemented. But it still fixes this issue.