chore: fix en deploy trigger and zh ch01 SUMMARY placeholder#46
Merged
Sunrisepeak merged 1 commit intomainfrom Apr 25, 2026
Merged
chore: fix en deploy trigger and zh ch01 SUMMARY placeholder#46Sunrisepeak merged 1 commit intomainfrom
Sunrisepeak merged 1 commit intomainfrom
Conversation
Two small follow-ups noticed while reviewing the ch02 PR:
1. online-ebook.yml only triggered on book/src/** changes, so an
en-only PR (e.g. an upcoming en translation of 15-variadic-templates)
would silently skip GitHub Pages redeploy. Add book/en/src/** to the
trigger paths.
2. zh SUMMARY.md had [...] as the visible label for ch01, left over
from the chapter being a stub since 2025-07. Replace with a proper
title matching the en side ("Defaulted and Deleted Functions"). The
chapter body itself is still a stub and remains tracked as TODO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review ch02 文档 PR 时顺手发现的两个小问题，合到一个清理 PR：
`online-ebook.yml` 触发路径只覆盖 zh — `paths: ["book/src/"]` 漏了 `book/en/src/`，所以纯 en 的 PR 不会触发部署。增加 en 路径条目，让 en-only 的章节翻译也能自动重新部署 GitHub Pages 站点。
zh `SUMMARY.md` 里 ch01 是 `[...]` 占位 — 从 2025-07 sunrisepeak 当时章节做 stub 时留下的占位标签。换成正经标题 `default和delete - 默认/删除函数`，与 en 侧 "Defaulted and Deleted Functions" 对齐。注意：ch01 的 .md 内容本身依旧是 stub，需要后续单独写正文。
Test plan