refactor(pm): move lockfile.cppm into pm/lock_io.cppm (PR-R2)#4
Merged
Sunrisepeak merged 1 commit intomainfrom May 8, 2026
Merged
refactor(pm): move lockfile.cppm into pm/lock_io.cppm (PR-R2)#4Sunrisepeak merged 1 commit intomainfrom
Sunrisepeak merged 1 commit intomainfrom
Conversation
Step two of the package-management subsystem refactor described in `.agents/docs/2026-05-08-pm-subsystem-architecture.md`. Strictly zero behavior change. * New module `mcpp.pm.lock_io` (`src/pm/lock_io.cppm`) carries the full lockfile read/write/serialize/hash implementation under the `mcpp::pm` namespace. * The existing `mcpp.lockfile` module (`src/lockfile.cppm`) is now a thin shim: re-exports `mcpp.pm.lock_io` and provides `using` aliases + inline forwarders so `mcpp::lockfile::Lockfile`, `::load`, ::write`, ... continue to resolve unchanged. The shim disappears once `cli.cppm` migrates to the `mcpp::pm::` qualified names directly. Verification: * `mcpp build` compiles unchanged. * `mcpp test` — 9/9 unit binaries pass. * e2e subset (02 / 09 / 12 / 23 / 27) all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step two of the package-management subsystem refactor described in
.agents/docs/2026-05-08-pm-subsystem-architecture.md.Strictly zero behavior change.
mcpp.pm.lock_io(src/pm/lock_io.cppm) carries thefull lockfile read/write/serialize/hash implementation under the
mcpp::pmnamespace.mcpp.lockfilemodule (src/lockfile.cppm) is now athin shim: re-exports
mcpp.pm.lock_ioand providesusingaliasesmcpp::lockfile::Lockfile,::load,::write,... continue to resolve unchanged. The shim disappears once
cli.cppmmigrates to themcpp::pm::qualified names directly.Test plan
mcpp build(worktree)mcpp test— 9/9 unit binaries pass