refactor(pm): move fetcher.cppm into pm/package_fetcher.cppm (PR-R3)#5
Merged
Sunrisepeak merged 1 commit intomainfrom May 8, 2026
Merged
Conversation
Step three of the package-management subsystem refactor described in `.agents/docs/2026-05-08-pm-subsystem-architecture.md`. Strictly zero behavior change. * Same shape as PR-R1 / PR-R2: the implementation moves under `mcpp::pm` in `src/pm/package_fetcher.cppm`, and the original `mcpp.fetcher` module becomes a thin shim that re-exports the new module and aliases every public type (`EventKind`, `ProgressEvent`, `LogEvent`, `DataEvent`, `ErrorEvent`, `ResultEvent`, `Event`, `EventHandler`, `CallError`, `CallResult`, `Fetcher`). * Scope deliberately narrower than the architecture doc's original "split into index_repo + index_store + package_fetcher" plan: the current `fetcher.cppm` body is a single xlings NDJSON client, not a three-way mix. The intended split is for the index-config feature (`.agents/docs/2026-05-08-package-index-config.md`) when those modules actually need to exist; doing it here would invent empty files for shapes that don't exist yet. Filed under "narrow each PR to behavior-preserving moves" from the refactor doc §10. Verification: * `mcpp build` compiles unchanged. * `mcpp test` — 9/9 unit binaries pass. * e2e subset (02 / 09 / 12 / 13 / 23 / 27) all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step three of the package-management subsystem refactor described in
.agents/docs/2026-05-08-pm-subsystem-architecture.md.Strictly zero behavior change.
Same shape as PR-R1 / PR-R2: implementation moves under
mcpp::pmin
src/pm/package_fetcher.cppm, and the originalmcpp.fetchermodule becomes a thin shim that re-exports the new module and
aliases every public type.
Scope deliberately narrower than the architecture doc's original
"split into
index_repo + index_store + package_fetcher" plan: thecurrent
fetcher.cppmis a single xlings NDJSON client, not athree-way mix. The intended three-way split is reserved for the
index-config feature work (per
2026-05-08-package-index-config.md)when those new abstractions actually need to exist. Inventing empty
modules here would violate the "behavior-preserving moves" rule
in §10 of the refactor doc.
Test plan
mcpp build(worktree)mcpp test— 9/9 unit binaries pass