refactor(pm): extract resolver into pm/resolver.cppm (PR-R4)#6
Merged
Sunrisepeak merged 1 commit intomainfrom May 8, 2026
Merged
refactor(pm): extract resolver into pm/resolver.cppm (PR-R4)#6Sunrisepeak merged 1 commit intomainfrom
Sunrisepeak merged 1 commit intomainfrom
Conversation
Step four of the package-management subsystem refactor described in `.agents/docs/2026-05-08-pm-subsystem-architecture.md`. Strictly zero behavior change. * New module `mcpp.pm.resolver` (`src/pm/resolver.cppm`) owns `resolve_semver`, `is_version_constraint`, and the `kXpkgPlatform` constant — previously sitting in `cli.cppm`'s anonymous namespace. Same signatures, same error strings, same platform key picking. * `cli.cppm` drops the originals (~80 lines) and qualifies the two call sites with `mcpp::pm::`. Verification: * `mcpp build` compiles unchanged. * `mcpp test` — 9/9 unit binaries pass. * e2e subset (02 / 09 / 12 / 23 / 27) all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step four of the pm subsystem refactor.
Strictly zero behavior change.
mcpp.pm.resolver(src/pm/resolver.cppm) ownsresolve_semver,is_version_constraint, and thekXpkgPlatformconstant — previously in
cli.cppm's anonymous namespace.cli.cppmdrops the originals (~80 lines) and qualifies the twocall sites with
mcpp::pm::.Test plan
mcpp build(worktree)mcpp test— 9/9 unit binaries pass