feat: add observability — log module, --verbose, file logging#68
Merged
Conversation
Three-layer observability system: 1. mcpp::log module (src/log.cppm): - File-based logging to ~/.mcpp/log/mcpp.log - Log rotation (10MB, 3 files) - Levels: off/error/warn/info/debug - Configured via MCPP_LOG_LEVEL env var or config.toml [log] 2. --verbose global flag: - Shows detailed progress on stderr (dim gray) - Auto-enables info-level file logging - Covers: toolchain install, package fetch, post-install fixup 3. Key path instrumentation: - Toolchain install flow (target, deps, fixup steps) - Package fetcher (resolve path, copy workaround, xlings calls) - xlings event forwarding (LogEvent, ErrorEvent) - Toolchain probing (compiler binary, sysroot, payload paths)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpp::logmodule with file-based logging, rotation, and verbose terminal output--verbose/-vflag that shows detailed progress on stderrconfig.toml [log]section for persistent log configurationUsage
Test plan
--verbose buildshows ninja verbose output--verbose toolchain installshows install flow on stderrMCPP_LOG_LEVEL=debugwrites to~/.mcpp/log/mcpp.log