fix(build): support xlings mcpp build dependencies#83
Merged
Conversation
Member
Author
|
Follow-up pushed in Implemented review follow-ups:
Local verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpplibs.capi.lua.compile_commands.json.Why
This preserves the mcpp-side fixes discovered while adding mcpp build support for
openxlings/xlings. Without these changes, the xlings build fails on local path indices, project-scoped xlings install paths, nested namespace dependency de-duplication, and C package headers with colliding names such ascommon.h.Validation
git diff --checkMCPP_HOME=/home/speak/.xlings/data/xpkgs/xim-x-mcpp/0.0.20 /home/speak/.xlings/data/xpkgs/xim-x-mcpp/0.0.30/bin/mcpp test -- --gtest_filter=Scanner.*:PmCompat.*:Toml.*MCPP_HOME=/home/speak/.xlings/data/xpkgs/xim-x-mcpp/0.0.20 /home/speak/.xlings/data/xpkgs/xim-x-mcpp/0.0.30/bin/mcpp build --print-fingerprintDraft PR for review and preservation; not ready to merge until review findings are addressed.