Skip to content

Conversation

@jonaellemos
Copy link
Contributor

No description provided.

@jonaellemos
Copy link
Contributor Author

Include service global for ToadMessage in the application web.
#82
@mcruzdev

Copy link
Owner

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jonaellemos for this pull request.

Could you execute a npm run prettir:write in the angular app?

I have some points about this pull request:

  • Shouldn't it be "toast" instead of "toad"?
  • With this implementation can we remove the p-toast from sign-up.component.html and sign-in.component.html? I would like to use it only in app.component.html, it is a doubt I am not a Angular expert.

@jonaellemos
Copy link
Contributor Author

jonaellemos commented Dec 5, 2025

@mcruzdev , I'm sorry for conflict the name`s: toast x toad.
Fixed the name service and remove local instance the toast component.
I'm too run prettier in the projects angular files.

Copy link
Owner

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@mcruzdev mcruzdev force-pushed the feature/toad-service branch from 146fcfd to bc7d7ed Compare December 6, 2025 02:26
@mcruzdev mcruzdev linked an issue Dec 6, 2025 that may be closed by this pull request
@mcruzdev mcruzdev merged commit 6eca5b8 into mcruzdev:main Dec 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: Centralize Toast for all application

2 participants