-
Notifications
You must be signed in to change notification settings - Fork 7
Closed
Labels
Description
Problem
Two related issues in the export command output:
1. Post-export hint uses raw outputDir instead of resolved path
ExportCommand.swift line 415:
output.plain(" 2. Test with: mcs pack add \(outputDir)")Should use the resolved outputURL.path (which the write method uses) to ensure the suggested command works with relative paths.
2. ExportError uses CustomStringConvertible instead of LocalizedError
PackWriter.swift lines 86-101: ExportError conforms to Error + CustomStringConvertible but the project convention (MCSError, ManifestError) is LocalizedError with errorDescription. ArgumentParser uses localizedDescription for error display, which may fall back to a generic message without LocalizedError conformance.
Fix
- Change
\(outputDir)to\(outputURL.path)in the hint - Change
CustomStringConvertibletoLocalizedErrorand renamedescriptiontoerrorDescription
From PR #178 review.
Reactions are currently unavailable