Fix v1→v2 migration detection with marker-based checks#15
Merged
Conversation
- Add extension marker detection to HookCheck so v1 hooks (missing `# --- mcs:hook-extensions ---`) are flagged and replaced on install - Add managed marker (`<!-- mcs:managed -->`) to command templates and CommandFileCheck so v1 commands trigger reinstall - Add bundled source comparison to SkillFreshnessCheck so updated skills in new binary versions are detected even when manifest hashes match - Simplify doctor --fix to cleanup/migration/permissions only; additive operations (install/register/copy) deferred to `mcs install` to avoid inconsistent manifest state - Remove dead `fixAction` property from CommandCheck - Add responsibility boundary documentation to CoreDoctorChecks header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# --- mcs:hook-extensions ---, commands must contain<!-- mcs:managed -->. Absence triggers reinstall onmcs install.SkillFreshnessCheckso updated skills in new binary versions are detected even when manifest-vs-installed hashes match.doctor --fixto cleanup/migration/permissions only. Additive operations (install/register/copy) are now exclusivelymcs install's responsibility to prevent inconsistent manifest state.Test plan
swift buildsucceedsswift testpasses (201 tests)mcs doctoron a v1 machine flags legacy hooks (FAIL), commands (WARN), and updated skills (WARN)mcs doctor --fixonly fixes permissions, does not install/replace filesmcs installon a v1 machine replaces legacy hooks and commands, prompts for branch prefix