Skip to content

[#144] Rename semver test functions and checkoutLockedVersions#181

Merged
bguidolim merged 1 commit intomainfrom
feature/144-rename-semver-tests
Mar 1, 2026
Merged

[#144] Rename semver test functions and checkoutLockedVersions#181
bguidolim merged 1 commit intomainfrom
feature/144-rename-semver-tests

Conversation

@bguidolim
Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • swift build compiles cleanly
  • swift build --build-tests compiles cleanly

- Rename test functions from semver* to versionCompare* to match VersionCompare type
- Rename checkoutLockedVersions to checkoutLockedCommits for consistency
Copilot AI review requested due to automatic review settings March 1, 2026 21:17
@bguidolim bguidolim enabled auto-merge (squash) March 1, 2026 21:19
@bguidolim bguidolim merged commit cdca8a9 into main Mar 1, 2026
5 checks passed
@bguidolim bguidolim deleted the feature/144-rename-semver-tests branch March 1, 2026 21:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames remaining “semver” and “locked versions” identifiers to align with the newer VersionCompare naming and commit-SHA-based locking semantics introduced in #179.

Changes:

  • Rename ExternalPackLoaderTests test functions from semver*versionCompare*.
  • Rename LockfileOperations.checkoutLockedVersionscheckoutLockedCommits.
  • Update SyncCommand’s --lock flow to call the renamed method and adjust the nearby comment wording.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Tests/MCSTests/ExternalPackLoaderTests.swift Renames VersionCompare-related test function identifiers for consistency with the VersionCompare type.
Sources/mcs/Install/LockfileOperations.swift Renames the lockfile checkout helper to reflect commit-based pinning.
Sources/mcs/Commands/SyncCommand.swift Updates --lock call site and comment to use “commits” wording and the new method name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants