[#144] Rename semver test functions and checkoutLockedVersions#181
Merged
[#144] Rename semver test functions and checkoutLockedVersions#181
Conversation
- Rename test functions from semver* to versionCompare* to match VersionCompare type - Rename checkoutLockedVersions to checkoutLockedCommits for consistency
There was a problem hiding this comment.
Pull request overview
Renames remaining “semver” and “locked versions” identifiers to align with the newer VersionCompare naming and commit-SHA-based locking semantics introduced in #179.
Changes:
- Rename
ExternalPackLoaderTeststest functions fromsemver*→versionCompare*. - Rename
LockfileOperations.checkoutLockedVersions→checkoutLockedCommits. - Update
SyncCommand’s--lockflow to call the renamed method and adjust the nearby comment wording.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Tests/MCSTests/ExternalPackLoaderTests.swift | Renames VersionCompare-related test function identifiers for consistency with the VersionCompare type. |
| Sources/mcs/Install/LockfileOperations.swift | Renames the lockfile checkout helper to reflect commit-based pinning. |
| Sources/mcs/Commands/SyncCommand.swift | Updates --lock call site and comment to use “commits” wording and the new method name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semver*toversionCompare*to match theVersionComparetype (renamed fromSemVerin [#144] Remove pack version field and peer dependency system #179)checkoutLockedVersionstocheckoutLockedCommitsfor consistency with commit-based pinningTest plan
swift buildcompiles cleanlyswift build --build-testscompiles cleanly