Fix orphaned fileHashes blocking pack removal#293
Merged
Conversation
- Purge fileHashes entries without corresponding files entries after file removal in unconfigurePack(), fixing packs stuck in "could not be removed" state on every sync - Add test seeding orphaned fileHashes to verify full pack removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
mcs sync --globalrepeatedly tries to remove packs that are already gone, printing:Root cause:
unconfigurePack()removes entries fromremaining.filesafter successful file deletion but never cleans upremaining.fileHashes. SincePackArtifactRecord.isEmptychecksfileHashes.isEmpty, orphaned hash entries (present infileHashesbut absent fromfiles) permanently prevent the pack from being fully removed from state.This data inconsistency was introduced by the conditional copyPackFile namespacing feature (aa7fd9a), which could remove files from
filesduring reconciliation while leaving stalefileHashesbehind.Changes
remaining.filesinunconfigurePack(), filterremaining.fileHashesto only keep entries whose key exists inremaining.files— handles both normal removal and orphaned statefiles, non-emptyfileHashes) and verifies the pack is fully removedTesting
unconfigureClearsOrphanedFileHashescovers the exact scenario