#244: Fix unconfigurePack silently discarding failed removals#306
Merged
#244: Fix unconfigurePack silently discarding failed removals#306
Conversation
- Replace unconditional array clears with per-item result switching - Failed removals stay in artifact record for retry on next sync - Adopt Set-collect-then-batch-remove pattern matching MCP/file removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unconfigurePack()unconditionally clearedremaining.brewPackagesandremaining.pluginsafter iterating removals, silently dropping failed items from the artifact record. Failed removals were never retried and users received no warning — leaving orphaned brew packages and plugins.Closes #244
Changes
remaining.brewPackages = []/remaining.plugins = []with per-itemRefCountedRemovalResultswitching.failed, keep the item inremainingand emitoutput.warn()so the end-of-method guard persists it for retryTest plan
swift testpasses locally (913 tests)swiftformat --lint .andswiftlintpass without violations