Add hook matcher support to techpack schema#315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
hookMatchersupport to the techpack YAML schema, allowing pack authors to specify a regex matcher that filters when a hook fires. This maps directly to Claude Code'smatcherfield onHookGroup, which was already round-tripped in settings JSON but never populated from the pack pipeline.Changes
matcher: String?toHookRegistrationstruct and thread throughSettings.addHookEntry(), YAML manifest decode/encode, sync composition (ConfiguratorSupport), export discovery (ConfigurationDiscovery), and YAML emission (ManifestBuilder)hookMatcherCodingKey with orphaned-metadata rejection (requireshookEvent, same ashookTimeout/hookAsync/hookStatusMessage)addHookEntry()(comparesgroups[index].matcheron theHookGrouplevel)docs/techpack-schema.md,skills/techpack-creator/references/techpack-schema.md, andskills/techpack-creator/SKILL.mdTest plan
swift testpasses locally (963 tests, 7 new)swiftformat --lint .andswiftlintpass without violationsChecklist for engine changes
LifecycleIntegrationTests)docs/techpack-schema.md, skill references)