Conversation
… paths - Add CrossPackCollisionDryRunTests verifying dryRun handles colliding hook destinations - Add doctor test verifying FileExistsCheck uses resolver-namespaced paths Closes #291
bguidolim
deleted the
autoagent/291-test-collision-resolver-dryrun-doctor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CrossPackCollisionDryRunTestsinLifecycleIntegrationTests— verifiesdryRunwith colliding hook destinations completes without error and writes no artifacts to disk, both from a clean state and after a priorconfigurecollidingHookDestinationsResolvedByDoctorinDoctorRunnerIntegrationTests— configures two packs with the same hook destination at namespaced paths, then verifies doctor passes (i.e.,FileExistsChecklooks at the resolver-namespaced paths, not the flat paths)Closes #291
Test plan
swift test --filter CrossPackCollisionDryRunTests— 2 tests passswift test --filter collidingHookDestinationsResolvedByDoctor— 1 test passesswift test) — 966 tests pass, 0 failuresswiftformatandswiftlintclean