#350: Remove deprecated 'mcs sync --update' flag#351
Merged
Conversation
- Drop the --update flag and its LockfileOperations.updatePacks() backing - Delete update-path tests; scrub --update from CLAUDE.md and docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #350
Summary
mcs sync --updatewas soft-deprecated one release ago (it warned and pointed atmcs update). It's fully superseded bymcs update, which fetches and re-applies across all configured scopes and — unlike--update— respects the opt-ingenerate-lockfileconfig instead of force-writing the lockfile. Now that the deprecation window has passed, this removes it so the CLI carries no deprecated surfaces and no divergent fetch-then-apply code path.Changes
mcs sync --updateis gone — invoking it now errors withUnknown option '--update'. Users who relied on it should switch tomcs update(pair withmcs config set generate-lockfile trueif they want a lockfile written).Test plan
swift testpasses locallyswiftformat --lint .andswiftlintpass without violationsmcs sync --update→ expect anUnknown option '--update'errormcs update→ fetches latest pack versions and re-applies across scopesmcs syncwithgenerate-lockfile: true→ still writesmcs.lock.yamlChecklist for engine changes
CLAUDE.md,docs/,techpack.yamlschema inExternalPackManifest.swift)